Skip to content

Missing contribution guidelines for SDK approvers #1268

@artur-ciocanu

Description

@artur-ciocanu

Expected Behavior

Currently the CONTRIBUTING.md file doesn't have enough instructions regarding SDK approvers. It would be good to document that:

  • Approvers might see the big 🟢 button for merge 😄 but they SHOULD NOT hit it, because permissions are NOT enforced and only maintainers should merge to main branch
  • Approvers should not use the auto-merge label, only maintainers can add this label
  • Anything else that is missing

Actual Behavior

Currently none of this is document in the CONTRIBUTING.md file.

Steps to Reproduce the Problem

Please check CONTRIBUTING.md file.

Release Note

RELEASE NOTE:

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions