Skip to content

Use camelCase on properties #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Jul 26, 2025

Description

Change the configuration on documentation to camelCase.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1466

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev mcruzdev requested review from a team as code owners July 26, 2025 02:12
@mcruzdev
Copy link
Contributor Author

@salaboy I added as camelCase to support both (spring support camelCase too), WDYT?

@salaboy
Copy link
Collaborator

salaboy commented Jul 26, 2025

@mcruzdev, thanks for the change, but it will be great if we can add some tests to see if these and the previous ones that you documented both work for the spring boot application.properties. I have the feeling that there are a couple of approaches implemented for different situations, and I am not sure if they are covered by tests. For example if you are using: dapr.client.httpEndpoint I think the endpoint is expected to have the port.

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
@mcruzdev mcruzdev force-pushed the issue-1466-camelcase branch from 1dbd120 to 8febfa8 Compare July 28, 2025 00:15
@mcruzdev
Copy link
Contributor Author

mcruzdev commented Jul 28, 2025

Hi @salaboy we already have a test for it (using kebab-case), I added another one to be sure.

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.51%. Comparing base (d759c53) to head (8febfa8).
⚠️ Report is 186 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1470      +/-   ##
============================================
+ Coverage     76.91%   78.51%   +1.59%     
- Complexity     1592     1891     +299     
============================================
  Files           145      234      +89     
  Lines          4843     5869    +1026     
  Branches        562      603      +41     
============================================
+ Hits           3725     4608     +883     
- Misses          821      938     +117     
- Partials        297      323      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Spring Boot properties to connect to remote Dapr Endpoints
2 participants