-
Notifications
You must be signed in to change notification settings - Fork 137
Python SDKDocs updates for v1.2 client #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@wcs1only @berndverst could you please help review how I branched here? The docs were sparse on branching technique for a submodule like PythonSDK. I did work in my own branch and pushed to that branch, since obviously I cannot and should not to the main. Please advise. I wonder if that's why the build check broke too? |
LGTM |
@paulyuk You did things right, the build failure looks unrelated, as another PR is failing in the same place. I suspect there may have been a change in one of our dependencies that might be tripping things up. Will take a look today. |
Looks related to protobuff library stubs missing for type checking. Either |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks for cleaning this up!
Thank you @wcs1only and @berndverst ! |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 49 49
Lines 1954 1954
=======================================
Hits 1733 1733
Misses 221 221 Continue to review full report at Codecov.
|
Description
Updated Python SDK docs for the client:
Issue reference
Fixes #1551
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: