Skip to content

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jun 12, 2021

Description

Updated Python SDK docs for the client:

  • changed all example links to point to the main branch, versus old setup branch 1+ years old
  • updated all sample code to reflect current 1.2 SDK for Python
  • added complementary Subscribe example to Publish & subscribe to messages section

Issue reference

Fixes #1551

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • [] Created/updated tests
  • Extended the documentation

@paulyuk paulyuk changed the title Paulyuk/sdkdocs client Python SDKDocs updates for v1.2 Jun 12, 2021
@paulyuk paulyuk changed the title Python SDKDocs updates for v1.2 Python SDKDocs updates for v1.2 client Jun 12, 2021
@paulyuk
Copy link
Contributor Author

paulyuk commented Jun 12, 2021

@wcs1only @berndverst could you please help review how I branched here? The docs were sparse on branching technique for a submodule like PythonSDK. I did work in my own branch and pushed to that branch, since obviously I cannot and should not to the main. Please advise. I wonder if that's why the build check broke too?

@berndverst
Copy link
Member

LGTM

@wcs1only
Copy link
Contributor

@wcs1only @berndverst could you please help review how I branched here? The docs were sparse on branching technique for a submodule like PythonSDK. I did work in my own branch and pushed to that branch, since obviously I cannot and should not to the main. Please advise. I wonder if that's why the build check broke too?

@paulyuk You did things right, the build failure looks unrelated, as another PR is failing in the same place. I suspect there may have been a change in one of our dependencies that might be tripping things up. Will take a look today.

@berndverst
Copy link
Member

@wcs1only @berndverst could you please help review how I branched here? The docs were sparse on branching technique for a submodule like PythonSDK. I did work in my own branch and pushed to that branch, since obviously I cannot and should not to the main. Please advise. I wonder if that's why the build check broke too?

@paulyuk You did things right, the build failure looks unrelated, as another PR is failing in the same place. I suspect there may have been a change in one of our dependencies that might be tripping things up. Will take a look today.

Looks related to protobuff library stubs missing for type checking. Either mypy --install-types or adding the types-protobuf requirement should resolve it. Agree this should be done in another PR. @wcs1only

Copy link
Contributor

@wcs1only wcs1only left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for cleaning this up!

@paulyuk
Copy link
Contributor Author

paulyuk commented Jun 14, 2021

Thank you @wcs1only and @berndverst !

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #224 (8b03147) into master (4522b8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files          49       49           
  Lines        1954     1954           
=======================================
  Hits         1733     1733           
  Misses        221      221           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4522b8c...8b03147. Read the comment docs.

@wcs1only wcs1only merged commit 5e6c6f5 into dapr:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants