-
Notifications
You must be signed in to change notification settings - Fork 137
Implement multi-app workflows #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e5e28e
to
f1e653d
Compare
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #844 +/- ##
===============================================
Coverage ? 87.17%
===============================================
Files ? 93
Lines ? 6159
Branches ? 0
===============================================
Hits ? 5369
Misses ? 790
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Albert Callarisa <albert@diagrid.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you also pls add an example for non-green paths?
I've added a couple of examples showing how it handles errors coming from both workflow and activities. |
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Adds support for multi-app workflow invocations, both child workflows and activities, just providing
app_id
in the callThe multi-app documentation is here: https://docs.dapr.io/developing-applications/building-blocks/workflow/workflow-multi-app/, and at the moment is fully supported in the Go SDK, and partially supported in the Java SDK.
This PR will make the multi-app functionality fully supported in the python SDK.