Fix minor pylint messages related to your pull request and merge pika master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close ioloop when cleaning up an instance of BlockingConnection. Fix/suppress several pylint findings.
…adsafe being called from same and from another thread
…kFromAnotherThread
…notherThread with debug logging to help debug test failure.
…thAckFromAnotherThread
…nerator-based consumer.
…ckFromAnotherThread
… new "ack from other thread" BlockingConnection tests.
…in AsyncTestCase.
… so that these IOLoops may be closed to release resources without risking closing of singletons which would break subsequent tests (since some adapters, such as torndado and asyncio make use of the singletons)
…orresponding RresourceWarning messages when running Python3 tests
….close(), poller close methods.
…p.stop and _PollerBase.stop. Technically, IOLoop.add_callback_threadsafe should be the only thread-safe method that can be used to delegate other non-thread-safe methods similarly to other asynchronous frameworks (twisted, tornado, etc.)
from a different thread than IOLoop is running in. Add an example of calling it via `add_callback_threadsafe()`. Use `add_callback_threadsafe()` to invoke ioloop.stop() from another thread in unit/select_connection_ioloop_tests.py
… newly-added tests.
…ncelEncountersCancelFromBroker
…ncountersCancelFromBroker
…plified TestConsumeGeneratorCancelEncountersCancelFromBroker
…ven error-prone feature with inconsistent default values across adapters and all of our examples set it to False for any adapter where it defaulted to True because it interferes with typial logic. Apps can stop their ioloop easily from connection-provided callbacks if they wish.
…ally committed to wrong branch This reverts commit 3ca1365.
… the removed arg stop_ioloop_on_close.
…lose Eliminate the `stop_ioloop_on_close` arg from all async connection adapters
closed before the call(s) to start() unwind. Implemented select_connection IOLoop tests: IOLoopCloseAfterStartReturnsTestSelect IOLoopCloseBeforeStartReturnsTestSelect IOLoopThreadStopTestSelect Implemented additaionl tests in acceptance/async_adapter_tests.py: TestAddCallbackThreadsafeRequestBeforeIOLoopStarts TestIOLoopStopBeforeIOLoopStarts
…callback Trying to debug Updates were rejected because the remote contains work that you do not have locally.
…stantiate_connection()
not channels or the connection is still opening, in which case there should be no channels.
closing the async connection before it is established to avoid triggering logic in the close code path that isn't ready to deal with it.
…estIOLoopStopBeforeIOLoopStarts acceptance test.
Implement add_callback_threadsafe in all connection adapters
…nnel.py. Inline unnecessary method `Connection._remove_callback()`.
…-docs Improved arg documentation of some callbacks in connection.py and channel.py
…celing-in-generator Implemented BlockingConnection acceptance tests for the consume generator encountering server's Basic.Cancel
vitaly-krugl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@darcoli, my specific changes are in commit 066ce02. The rest is just merging of pika master with your PR.