Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced note->link feature request (#12) #16

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

acer123acer123
Copy link
Contributor

Implemented feature documented in #12. If the note is a valid-formatted URL then it will be converted to a URL during the build phase.

@darekkay
Copy link
Owner

darekkay commented Oct 6, 2020

Thanks Chris, the solution looks good 👍

Just two remarks: could you please:

  1. ... fix the ESLint errors (see Travis output). Running yarn lint:fix or npm run link:fix should fix most of the issues. I consider the no-new error a valid use case, so you can ignore this issue by adding the following line before new URL:
// eslint-disable-next-line no-new
  1. ... adjust the existing test case by adding an example http* entry here and adjusting the expected array accordingly?

@acer123acer123
Copy link
Contributor Author

acer123acer123 commented Oct 6, 2020 via email

@acer123acer123
Copy link
Contributor Author

acer123acer123 commented Oct 6, 2020 via email

@acer123acer123
Copy link
Contributor Author

acer123acer123 commented Oct 6, 2020 via email

@darekkay
Copy link
Owner

darekkay commented Oct 6, 2020

@acer123acer123 Thanks, looks good now 😃 I've seen you have figured it out already, but here's just a small tip. In JavaScript projects, you will almost always find a package.json file, where all scripts are defined. There are often scripts called test (= unit tests) and lint (= code quality and project guidelines), which you can run with npm run <script> or yarn <script>. This way, developers don't have to care which libraries/tools are actually being used for which project.

@darekkay darekkay merged commit d8d2fec into darekkay:master Oct 6, 2020
@darekkay
Copy link
Owner

darekkay commented Oct 6, 2020

@all-contributors please add @acer123acer123 to maintenance

@allcontributors
Copy link
Contributor

@darekkay

I've put up a pull request to add @acer123acer123! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants