-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced note->link feature request (#12) #16
Conversation
Thanks Chris, the solution looks good 👍 Just two remarks: could you please:
|
I’m working on that as we speak. Thanks!
|
I have 1. complete (not yet committed) but I need a hint for 2. I’m not a developer by trade (I’m a DevOps Consultant Engineer at Progressive). I work very closely with developers but my skillset is around architecture, CI/CD, etc. I’ve written applications and learned languages as needed. So, for this one, I am learning JavaScript (I’ve never really messed with it in any kind of depth). Can you point me to the testing tool you are using so that I can run it manually on my local machine before committing the changes?
Thanks
|
Never mind. I figured it out by looking at a successful Travis build.
|
@acer123acer123 Thanks, looks good now 😃 I've seen you have figured it out already, but here's just a small tip. In JavaScript projects, you will almost always find a |
@all-contributors please add @acer123acer123 to maintenance |
I've put up a pull request to add @acer123acer123! 🎉 |
Implemented feature documented in #12. If the note is a valid-formatted URL then it will be converted to a URL during the build phase.