Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another clipping of a focus frame #25

Closed
skndn60 opened this issue Mar 12, 2013 · 8 comments
Closed

Another clipping of a focus frame #25

skndn60 opened this issue Mar 12, 2013 · 8 comments

Comments

@skndn60
Copy link

skndn60 commented Mar 12, 2013

For drop down boxes the focus ring gets clipped. This happens when I tab from the text area to the drop down. Strangely, when I tab out of the drop down into the next and then back again into the drop down, the focus ring is properly displayed.

Screen Shot 2013-03-12 at 13 29 51

@darklow
Copy link
Owner

darklow commented Mar 12, 2013

What browser/version and OS is that?

@skndn60
Copy link
Author

skndn60 commented Mar 12, 2013

Mac OS X 10.8.2 running Chrome 25.0.1364.160

@darklow
Copy link
Owner

darklow commented Mar 12, 2013

Offtopic: If your description field is not required, it means it could be empty. But for empy textarea ir takes too much space. I suggest you use AutosizedTextarea in such situations, it will save you a lot of space! There is also link to demo in documentation.

@skndn60
Copy link
Author

skndn60 commented Mar 12, 2013

Thanks for the tip.

Noticed another thing while investigating this: there's a margin -1px on .control-group .controls which hides the horizontal border between controls in the control area of a fieldset. When I disable that border, the horizontal border between controls in the control area shows up.

Not sure whether this is intentional or not. I think either way looks good as the border is extremely subtle, as in "hardly noticeable"....

Screen Shot 2013-03-12 at 13 48 14

@darklow
Copy link
Owner

darklow commented Mar 12, 2013

It was intentional, in few situations that line can be good thing, but when you have lot of fields, every small detail creates additional mess and if you have lot of fields, it is better to avoid any additional lines if possible.
Here for example, with the lines form get's messy:
image

While without it looks much cleaner:
image

@darklow
Copy link
Owner

darklow commented Mar 13, 2013

Just tested on Mac and Chrome this form on demo app:
and to me drop downs look like they should be:

Screen Shot 2013-03-13 at 08 06 44

Are you sure you didn't override any style?

@skndn60
Copy link
Author

skndn60 commented Mar 13, 2013

I think it only happens when there's a TextArea above the dropdown...

@darklow
Copy link
Owner

darklow commented Mar 17, 2013

Could you please check this issue with latest develop version?
Fixing/refactoring multiline labels could fix this issue too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants