Layout breaks with read only field with null value

[skndn60]

On an entry form with a read only field with a null value, the layout breaks. See attached sample with a read only field Phone number with a null value: white area of label breaks into grey coloured data area.

See also issue 29

[darklow]

Could not reproduce.

1. are you using latest development branch version?
2. what is the field class for this field?
3. Could you please check the content (html) of that empty cell, it should be like this:

<div class="controls">
    <span class="readonly"></span>
</div>

[skndn60]

1. I downloaded yesterday evening.
2. I do not assign a specific field class. The fields that should be read-only are based on a business rule which gets applied by overriding the method get_readonly_fields in the model admin class.
3. See below:

<div class="control-group form-row field-phone ">
  <div>
    <div class="control-label">
      <label>Phone:</label>
    </div>
    <div class="controls">
      <span class="readonly"></span>
    </div>
  </div>
</div>

[darklow]

Could you please check this issue with latest develop version? Fixing multiline labels should fix this issue too

[skndn60]

AFAIK both issues still persist with latest development version:

[darklow]

This is very strange, are you sure you run collectstatic in case if this is with Debug=False or emptied browser cache?

1. Also i see horizontal lines for labels are gone, is this a new bug or your customization?
2. Is this latest Chrome/Mac?

I tested on windows for both Firefox and Chrome and everything looks perfect. Can't believe there is so much difference just because of Mac, because as far as i know Chrome uses same rendering engine for both win and mac.

[skndn60]

Hmm... my site appears broken since that last update. I have to figure out what went wrong first....

[darklow]

One new thing in referenced commit was new wrapper / tag for fieldset.html. In case you extend and use your own fieldset.html, you should update it (see commit changes)

[skndn60]

Right, I forgot to copy overridden templates to my templates/admin directory. Looked pretty scary :-( .... I can confirm that both issues #29 and #33 are fixed now. I tested on OS X with Chrome, Firefox and Safari. With Safari you only get a squeezed layout for layout of multi line labels. Probably a Safari bug...

Chrome:

Safari:

[darklow]

Good :) Could you take a look on #25, is it fixed too?

[skndn60]

#25 is fixed as well.

[darklow]

3 issues with 1 commit - not bad :) ok, closing issues, time to sleep.