Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long labels at end of fieldset mess up layout #29

Closed
skndn60 opened this issue Mar 16, 2013 · 6 comments
Closed

Long labels at end of fieldset mess up layout #29

skndn60 opened this issue Mar 16, 2013 · 6 comments
Labels

Comments

@skndn60
Copy link

skndn60 commented Mar 16, 2013

When I add a field with a label that overflows the label area for that field at the end of a fieldset, the layout is slightly messed up: The white area of the label area continues into the field values area.

Screen Shot 2013-03-16 at 10 43 08

@darklow
Copy link
Owner

darklow commented Mar 18, 2013

Unfortunately this solution of fixing multiline labels encountered new issues, some impossible to fix.
I'll have to go back where i started and do new refactoring, actually not much solutions left, either background image or display: table. I think this time i'll have to go simple and stable way over semantics.

@darklow
Copy link
Owner

darklow commented Mar 18, 2013

Sorry for bothering you again. Just refactored all the fieldset logic again.
Could you please check #25, #29, #33 again and see if everything is ok now? Thanks

@skndn60
Copy link
Author

skndn60 commented Mar 18, 2013

No problem but will be later tonight.

@skndn60
Copy link
Author

skndn60 commented Mar 18, 2013

I'm due a deployment tonight and I'm tight for time at the moment. I'll download tomorrow and check then... Apologies for the delay.

@skndn60
Copy link
Author

skndn60 commented Mar 19, 2013

I just downloaded the development release and #25, #29 and #33 still look ok.

@darklow
Copy link
Owner

darklow commented Mar 19, 2013

Thanks, that's very good. Finishing docs, tests, new menu configs and releasing new version, hopefully today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants