This repository has been archived by the owner on Apr 18, 2020. It is now read-only.
added the possibility of customizing the color of different parts #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awsome! Thanks. |
|
thanks @B0jan :) |
|
+1 |
1 similar comment
|
+1 |
|
This is really cute, nice work! I don't plan to merge this, but I'd like to keep this open as an issue to figure out how to address it for #11. I think that CSS can reference SVG elements, so maybe this is as simple as applying a class to the relevant SVG parts so that one can recolor them as desired. |
SLEET was renamed to RAIN_SNOW. The original SLEET was restored. The original index.html was also restored.
Added separate coloring for the fogbank.
|
What am I missing - why is this not being merged? |
|
@Julix91 because they want to work with plain SVG. I also think it's a lot better than a canvas ;) |
|
Skycons is no longer maintained; please fork to do any further work on it! |
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two options : "monochrome" a boolean which is false by default and "colors", an object to configure the colors of different elements like sun, cloud etc..
When monochrome is set to false , icons are colored like this
You can pass custom colors in the options. I also edited the README to show how to configure this new feature