-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Canon CR3 raw files #2170
Comments
I just wanted to add that I have also uploaded sampler RAW and C-RAW from an EOS R - and I would do anything else in my power to help support the efforts to reverse-engineer the CR3 format and get it into Darktable. |
C-RAW (*.CR3) use Canon 250D so i need support too. |
On the ongoing effort to reverse-engineer the proprietary CR3 format: https://github.com/lclevy/canon_cr3 |
cr3-support is now available in LibRaws master-branch. |
That is fantastic news!! Well done to all that helped! |
This issue did not get any activity in the past 30 days and will be closed in 7 days if no update occurs. Please check if the master branch has fixed it since then. |
Nope, still not solved in master. |
I have a Canon EOS Rebel SL3 (also known as EOS 250D and EOS Kiss X10) and I still can´t get my files read by DarkTable, I had to use the Adobe DNG Converter to make the files usable with the app but still no direct support, highly interested in this compatibility, if you need any sample shots or something I would love to help. |
For those needing a workaround, you can use Adobe's DNG converter https://helpx.adobe.com/photoshop/using/adobe-dng-converter.html Obviously native support would be very much appreciated! |
Yup, also using DNG converter, but, particularly with C-RAW files, having to decompress them just for post-processing really bloats the disk. |
There is no Linux version of DNG Converter 👎 I have to take RAW+JPEG and stick with JPEGs for now, hoping that one day I will be able to process the RAWs in Darktable (being my favourite tool). At least RawTherapee added limited support recently. It's a shame Adobe ignores Linux, it's a shame they don't opensource the CR3 specification and I seriously blame them for not warning their customers :( |
FWIW there is a reverse-engineering spec here https://github.com/lclevy/canon_cr3 as well as the mentioned earlier support in other libraries like LibRAW, but, my understanding is that devs are mainly concerned about legality of using a reverse-engineered spec? I wonder how LibRAW deals with this issue? (if it does) |
We know :) Pretty much CR3 is possible, just needs exiv2 support and it's stalled on exiv2 supporting it. |
Almost one year already. The speed of Open Sauce development is incredible. |
Has Canon released non-NDA specs for CR3? Has Canon cleared open source of any possible patent infrigment? Had nobody objected to CR3 support being done in exiv2? Have you contacted Canon and asked them to provide (or at least open line of communication) specs? Anyway, slowdown on exiv2 side is mostly caused by exiv2 community-member(s) objecting to including possibly patent infringing code (it wouldn't be, I asked law advisor) and thus halting development and discouraging it. I thought I could work on it, but life & paying bills got in the way so I hope Mr. Mills or somebody else will be able to implement relevant stuff on exiv2 side. On darktable's side support is possible as it currently resides on experimental branch (no, that can't be enabled without exiv2 working) |
I wonder if, as a workaround, Darktable could provide LibRAW support in form of a plugin? I know it used to use LibRAW in the past, and then switched to custom decoder for performance reasons (I think?), but could LibRAW at least be used as a fallback for unsupported formats so that it would solve cases like this until a better version is available? |
I'm also interested in the support of CR3 in darktable. Can anyone give us a status? How can we help? |
@isolin the Adobe converter works flawless using Wine. Not the best solution, but works for me in the meantime. |
For those impatient: Note that I save in RAW not cRAW. |
Note that solution from @daniel-lucio is also converting to DNG, like couple others in the thread. It's not a support in Darktable. |
I know, that's why I said for the impatient. |
Closing here, there is a similar feature request open on Rawspeed project, and Exiv2 is the sole responsible for that lack of support. |
It would seem that Linux users are going to be having the comparatively hardest time uninstalling this thing if they ever wanted to, not to suggest that they ever should... but is there any input on potentially packaging DarkTable for Linux? Preferences? |
I think appimage or snap are probably the more ubiquitous ways of packaging that make it easy. Appimage can also be updated, the way freecad was doing it with appimage updater, so the user doesn't need to pull a whole new image for every new version. |
What do you have against Flathub? Simply that you use Snap instead? I agree about |
Actually I just forgot about that option 😅 |
May I suggest moving this discussion to https://discuss.pixls.us/ |
Sorry, is that a company behind DarkTable? |
No but thats the "official" forum for all things open source photography including darktable. |
Seriously, any reason why cytrinox/rawspeed can't be merged? Willing to help w/ this effort |
I don't have the answer to this, but for sure if cytrinox/rawspeed is not merged soon dt 3.8 won't support CR3. |
Bummer, I'm able to build myself with CR3 support but it's certainly a pain! Would be so great if it were offered out of the box |
I can help, according to my skills. What can I do in order to get this accomplished? |
I'm trying geoland86's steps to try to get cr3 files working but git checkout canon_cr3 returns "did not match any file(s) known to git" any suggestions. Somewhat of a noob but trying damn hard to make this work. |
I think the process has been mentioned here often enough I'd say. Look for older posts above |
Make sure you remove the raw speed directory and replace it with cytrinox/rawspeed. The cr3 branch is in that repo |
Can you link to the specific steps? I don't see this username in the thread from a page search Edit, found it: #2170 (comment) |
Looks like that was it. Removed rawspeed directory that was there and cloned from cytrinox/rawspeed repo and was able to get checkout canon_cr3 branch. Fingers crossed on the exiv2. I built with bmff enabled before cloning darktable. Do I need to change anything in the DT directory for exiv2 or will it used the version installed? |
error with exiv2. Any suggestions? darktable/src/common/exif.cc: In function ‘char* dt_exif_xmp_read_string(int)’: I feel like i'm so close. latest version of exiv2 installed but i get [swaine@fedora build]$ exiv2 --version |
The api changed in latrst version, you must use 0.27 maintenance branch |
I had that, just removed the private and it worked 😎 |
Well im pretty sure I fixe the exiv2 issue now im getting this lol.
I built before without an error from rawspeed. Thanks for the comments on exiv2. Any thoughts? |
Rebuild entirely (remove build directory and start from scratch) |
@TurboGit, we should consider locking this issue, because it turned into support forum, too much noise. There's nothing to discuss about the feature itself, just waiting for rawspeed. |
moving the issue to Pixl. Thank you all for the support. |
Good thought. I've added more input here. |
Locked now. |
Canon CR3 raw files are currently not supported. These are used by a few of Canon's new cameras at this point. At a minimum, the M50, SX70 HS, EOS R, and EOS RP. https://raw.pixls.us/ has samples for the M50, EOS R, and EOS RP.
Someone appears to have already done a lot of the reverse engineering here:
https://github.com/lclevy/canon_cr3
Let me know if there is anything that can be done to help, including testing, more samples, or development assistance.
The text was updated successfully, but these errors were encountered: