Fix various demosaicer issues with amd drivers #10841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboGit
added
bugfix
TurboGit
pushed a commit
that referenced
this pull request
Jan 11, 2022
* rcd fixes * ppg fixes * rest of fixes * Safety for the border region for rcd opencl demosaicer
TurboGit
reviewed
Jan 11, 2022
jpellegrini
pushed a commit
to jpellegrini/darktable
that referenced
this pull request
Jan 14, 2022
* rcd fixes * ppg fixes * rest of fixes * Safety for the border region for rcd opencl demosaicer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @piratenpanda in #10778
seemed to be related to NaNs fired up the pipeline. We investigated this further and suspected driver issues but could isolate the underlying problem. Especially the border handling algorithms for ppg and rcd seemed to be a problem (i took the border code for rcd from old ppg code). As we know from other issues ( #9235 ) amd drivers are more picky about this.
I checked places where writing output was not absolutely safe to have fully correct data and ensured writing at least 0 instead of NaN via
fmax(0.0f, val)likely
Fixes #10778
Fixes #10082