fix lua dt.gui.mimic in script section #14020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today? darktable-org/lua-scripts#410 Sorry, I thought I had already done it. It was still sitting in a branch waiting to be pushed. |
Yes please and thank you! |
dterrahe
added
bugfix
|
@dterrahe @wpferguson : Given the discussion above let me know when this is ready for integration. TIA. |
|
It's ready. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to make lua widget proxies work after the
script_manager_running_scriptvariable has been introduced in script_manager.lua, as discussed here#13579 (comment)
@wpferguson do you have a timeline for this? It shouldn't hurt anybody who isn't using master and those who are could give feedback on the problems introduced. Shortcuts not working until remapped maybe.
One thing I noticed is that the bauhaus widgets that script_manager sets up for itself now end up in the last module activated. So you'll want to define a dedicated
script_manager_running_scriptvalue for the manager as well.