Check for sane data in old clipping module #17097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to fix bugs in that module any longer, yet it is good to avoid crashes due to insane roi_out data calculations.
jenshannoschwalm
force-pushed
the
clipping_sanity
branch
from
8ee36dc
to
5173d96
Compare
|
fixed, squashed and force-pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to fix bugs in that module any longer, yet it is good to avoid crashes due to insane roi_out data calculations.
Fixes #17095
As that module is deprecated there will be no relevant bug-fixing. Yet at least we should make dt stable and not crashing due to insane roi_out calculations.
See the provided image and sidecar in the OP issue.
I guess this should be safe for 4.8.1 as we have the same string already in codebase. Right?