Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

TranscludingComponentFactory Passes a Wrong Element to onShadowRoot  #1435

@vsavkin

Description

@vsavkin

TranscludingComponentFactory passes the component's element to onShadowRoot, whereas it should pass an instance of EmulatedShadowRoot.

This means the following will throw:

@Component(useShadowDom: false)
class MyComponent implements ShadowRootAware {
  void onShadowRoot(ShadowRoot shadowRoot) {}
}

Whereas the following will not:

@Component(useShadowDom: false)
class MyComponent implements ShadowRootAware {
  void onShadowRoot(shadowRoot) {} //here shadowRoot is not really a shadow root!!!
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions