This repository was archived by the owner on Feb 22, 2018. It is now read-only.
chore(reporter): record lexer benchmark results #1159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchmark/_reporter.dart
Outdated
|
a few minor comments, otherwise LGTM |
|
@chirayuk Anything blocking this change? Can we land it? |
|
@chirayuk can you address Vic's concerns. Otherwise LGTM |
|
Folks – sorry I've been tardy on this PR. I'll clean this up next week and merge it in. Thanks! |
benchmark/_reporter.dart
Outdated
There was a problem hiding this comment.
Debugging message? Remove?
|
Looks good after the comments are addressed and the tests are passing. |
chirayuk
force-pushed
the
master
branch
2 times, most recently
from
8fd235c to
50e2645
Compare
|
@chirayuk can you review one last time, rebase, and merge please? |
This initial version sends benchmark metrics to the backend server. Visit https://ng-dash.appspot.com/commit/fb2aa60a584dd4b2bbb3d30e8fcd4c588f8669ed or https://ng-dash.appspot.com/all to see an example. (github: https://github.com/chirayuk/ng-dash) In this version, only Dart code run from the command line is able to record such reports. The code in benchmark/_reporter.dart handles sending the data to the server. A future version will mode this code into a locally running proxy server enabling browser based Dart code to send such reports while still including the information from the build environment. Reading data from the report server does not require any auth. See a simple example at chirayuk/ng-dash@ex_01 Writing data requires authentication. Specifically, the REST server requires two cookies set: user_email and user_secret. (user_email does not have to be a valid e-mail just like AppEngine user e-mails.) Of these, user_secret is meant to be secret and should be safeguarded. For Travis, user_email is "travis-ci.org" and user_secret is encrypted in the .travis.yml. Refer http://docs.travis-ci.com/user/build-configuration/#Secure-environment-variables for details on how this is done.
chirayuk
added a commit
that referenced
this pull request
Oct 8, 2014
This initial version sends benchmark metrics to the backend server. Visit https://ng-dash.appspot.com/commit/fb2aa60a584dd4b2bbb3d30e8fcd4c588f8669ed or https://ng-dash.appspot.com/all to see an example. (github: https://github.com/chirayuk/ng-dash) In this version, only Dart code run from the command line is able to record such reports. The code in benchmark/_reporter.dart handles sending the data to the server. A future version will mode this code into a locally running proxy server enabling browser based Dart code to send such reports while still including the information from the build environment. Reading data from the report server does not require any auth. See a simple example at chirayuk/ng-dash@ex_01 Writing data requires authentication. Specifically, the REST server requires two cookies set: user_email and user_secret. (user_email does not have to be a valid e-mail just like AppEngine user e-mails.) Of these, user_secret is meant to be secret and should be safeguarded. For Travis, user_email is "travis-ci.org" and user_secret is encrypted in the .travis.yml. Refer http://docs.travis-ci.com/user/build-configuration/#Secure-environment-variables for details on how this is done. Closes #1159
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial version sends benchmark metrics to the backend server.
Visit https://ng-dash.appspot.com/commit/fb2aa60a584dd4b2bbb3d30e8fcd4c588f8669ed
or https://ng-dash.appspot.com/all to see an example. (github:
https://github.com/chirayuk/ng-dash)
In this version, only Dart code run from the command line is able to
record such reports.
The code in benchmark/_reporter.dart handles sending the data to the
server. A future version will mode this code into a locally running
proxy server enabling browser based Dart code to send such reports while
still including the information from the build environment.
Reading data from the report server does not require any auth. See a
simple example at chirayuk/ng-dash@ex_01
Writing data requires authentication. Specifically, the REST server
requires two cookies set: user_email and user_secret. (user_email does
not have to be a valid e-mail just like AppEngine user e-mails.) Of
these, user_secret is meant to be secret and should be safeguarded. For
Travis, user_email is "travis-ci.org" and user_secret is encrypted in
the .travis.yml. Refer
http://docs.travis-ci.com/user/build-configuration/#Secure-environment-variables
for details on how this is done.