This repository was archived by the owner on Feb 22, 2018. It is now read-only.
perf(view factory): 14% Precompute linking information for nodes #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Default TreeComponent benchmark dropped from 572ms to 501ms Closes dart-archive#1194
|
Sweet! |
There was a problem hiding this comment.
could you add comment why do we need this field?
There was a problem hiding this comment.
Would caching the list be more efficient ? It could prevent calling querySelectorAll twice
There was a problem hiding this comment.
@vicb, no -- NodeLinkingInfo is created by inspecting the template, where _link is operating on clones of the template. They are two sets of nodes which have the same structure.
|
LGTM |
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
The Default TreeComponent benchmark dropped from 572ms to 501ms Closes dart-archive#1194 Closes dart-archive#1196
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
The Default TreeComponent benchmark dropped from 572ms to 501ms Closes dart-archive#1194 Closes dart-archive#1196
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Default TreeComponent benchmark dropped from 572ms to 501ms
Closes #1194