This repository was archived by the owner on Feb 22, 2018. It is now read-only.
fix: remove analyze warnings #1411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vsavkin I've made you the assignee, I think you wrote that code. |
|
LGTM |
|
@jbdeboer Travis looks fine. May be someone relaunch the test ? |
|
@vicb I did that. Sorry, I should have let you know. I'm merging it into master now. |
|
That's not a problem. Thanks for having done that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweaks to remove analyzer warnings:
noSuchMethodseems like a limitation of the analyzer,@Injectablemust not be put on abstract class - we don't need it when doing value binding