-
Notifications
You must be signed in to change notification settings - Fork 216
feat(change-detection): Initial implementation of new change-detection algorithm #434
Conversation
lib/change_detection/ast.dart
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=>
here and below
I have started to add some changes (including my above comments) to the original PR, see mhevery#2 |
@vicb thanks for your help on this, they are really helpful comments. I will get to merging these in on Monday. |
@mhevery most my comments above have been fixed in the PR to your own repo. If you agree with the changes it would be great to merge this PR into your repo so that changes would be visible here in the main repo. I do have a better understanding of the algo right now and would like to explore further enhancement next week (Using Iterator which I think are not used enough in Angular.dart but also other Dart libs in general). |
Thanks for doing such awesome work! Your effort is appreciated. I think it On Sun, Jan 26, 2014 at 8:43 AM, Victor Berchet notifications@github.comwrote:
|
@mhevery you already replied to the questions I had for now. I may might ask for more next week. I think you are the one I should thank for Angular and its Dart port. |
BTW, here is a design doc: https://docs.google.com/document/d/10W46qDNO8Dl0Uye3QX0oUDPYAwaPl0qNy73TVLjd1WI comment at will. |
:-) On Sun, Jan 26, 2014 at 8:52 AM, Victor Berchet notifications@github.comwrote:
|
…n algorithm. The classes are not yet hooked up to angular scopes yet, so so far this is a stand alone code.
Merged @vicb comments and push new version. This one also includes additional commit for Scope2 and hookup to the new Lexer/Parser. Eagerly awaiting your comments. |
I'll try to work on adding Iterator and a few other changes today or tomorrow |
MERGED: 0c7df96 |
The classes are not yet hooked up to angular scopes yet, so so far this is a stand alone code.