Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Jan 24, 2014

The classes are not yet hooked up to angular scopes yet, so so far this is a stand alone code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> here and below

@vicb
Copy link
Contributor

vicb commented Jan 25, 2014

I have started to add some changes (including my above comments) to the original PR, see mhevery#2

@mhevery
Copy link
Contributor Author

mhevery commented Jan 26, 2014

@vicb thanks for your help on this, they are really helpful comments. I will get to merging these in on Monday.

@vicb
Copy link
Contributor

vicb commented Jan 26, 2014

@mhevery most my comments above have been fixed in the PR to your own repo. If you agree with the changes it would be great to merge this PR into your repo so that changes would be visible here in the main repo.

I do have a better understanding of the algo right now and would like to explore further enhancement next week (Using Iterator which I think are not used enough in Angular.dart but also other Dart libs in general).

@mhevery
Copy link
Contributor Author

mhevery commented Jan 26, 2014

Thanks for doing such awesome work! Your effort is appreciated. I think it
is great that you want to explore this more in depth. Please let me know
how I can better support you.

On Sun, Jan 26, 2014 at 8:43 AM, Victor Berchet notifications@github.comwrote:

@mhevery https://github.com/mhevery most my comments above have been
fixed in the PR to your own repo. If you agree with the changes it would be
great to merge this PR into your repo so that changes would be visible here
in the main repo.

I do have a better understanding of the algo right now and would like to
explore further enhancement next week (Using Iterator which I think are not
used enough in Angular.dart but also other Dart libs in general).


Reply to this email directly or view it on GitHubhttps://github.com//pull/434#issuecomment-33321322
.

@vicb
Copy link
Contributor

vicb commented Jan 26, 2014

@mhevery you already replied to the questions I had for now. I may might ask for more next week.

I think you are the one I should thank for Angular and its Dart port.

@mhevery
Copy link
Contributor Author

mhevery commented Jan 26, 2014

BTW, here is a design doc: https://docs.google.com/document/d/10W46qDNO8Dl0Uye3QX0oUDPYAwaPl0qNy73TVLjd1WI comment at will.

@mhevery
Copy link
Contributor Author

mhevery commented Jan 27, 2014

:-)

On Sun, Jan 26, 2014 at 8:52 AM, Victor Berchet notifications@github.comwrote:

@mhevery https://github.com/mhevery you already replied to the
questions I had for now. I may might ask for more next week.

I think you are the one I should thank for Angular and its Dart port.


Reply to this email directly or view it on GitHubhttps://github.com//pull/434#issuecomment-33321742
.

…n algorithm.

The classes are not yet hooked up to angular scopes yet, so so far this is a stand alone code.
@mhevery
Copy link
Contributor Author

mhevery commented Jan 29, 2014

Merged @vicb comments and push new version. This one also includes additional commit for Scope2 and hookup to the new Lexer/Parser. Eagerly awaiting your comments.

@vicb
Copy link
Contributor

vicb commented Jan 29, 2014

I'll try to work on adding Iterator and a few other changes today or tomorrow

@mhevery mhevery closed this Jan 29, 2014
@mhevery mhevery reopened this Jan 29, 2014
@mhevery
Copy link
Contributor Author

mhevery commented Jan 29, 2014

MERGED: 0c7df96

@mhevery mhevery closed this Jan 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants