Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Conversation

blois
Copy link

@blois blois commented Feb 10, 2014

Primary change is exposing parseHtml on html_extractor to allow externally driving it rather than using a crawler.

@mhevery mhevery self-assigned this Feb 11, 2014
… from Dart transformers.

Primary change is exposing parseHtml on html_extractor to allow externally driving it rather than using a crawler.
mhevery pushed a commit to mhevery/angular.dart that referenced this pull request Feb 12, 2014
Slight refactoring of expression extractor to make it easier to drive from Dart transformers.

Primary change is exposing parseHtml on html_extractor to allow externally driving it rather than using a crawler.

Closes dart-archive#537
@blois
Copy link
Author

blois commented Feb 12, 2014

Fixed test issue (tests weren't updated for syntax change).

@mhevery
Copy link
Contributor

mhevery commented Feb 12, 2014

This change fails the build because it causes analyzer warnings. Could you have a look?

Also your commit messages do not conform to https://github.com/angular/angular.dart/blob/master/CONTRIBUTING.md#commit-message-format

Please reword

mhevery pushed a commit to mhevery/angular.dart that referenced this pull request Feb 15, 2014
Slight refactoring of expression extractor to make it easier to drive from Dart transformers.

Primary change is exposing parseHtml on html_extractor to allow externally driving it rather than using a crawler.

Closes dart-archive#537
@blois blois closed this in 1acb44d Feb 15, 2014
@blois blois deleted the refactor_expressions branch March 24, 2014 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants