feat(scope): Automatically $digest futures inside of $apply.

[jbdeboer]

No description provided.

[mhevery]

I don't think this is the right place for the zone. I think it should be in the root of angular bootstrap. Since it is not just HTTP futures which need to be zoned but any future anywhere in the codebase.

[pavelgj]

Please make sure this works in dart2js.

[jbdeboer]

I sat down with Misko and we hashed out a better approach. I'll update this PR when it is ready.

[jbdeboer]

The runZoned logic now runs inside of scope.$apply.

If you wrap Futures in a scope.$apply, we will digest the scope whenever an asynchronous callback is run.

[mhevery]

it you throw toThrow, then you are starting a new stack trace. What you want to do is to re-throw, which is just throw; with no arg.

but if toThrow is null then you eat exception? Can you explain this logic?

[jbdeboer]

toThrow is passing the exception from the onError handler out to the $apply function.

If we rethrow the exception in the onError handler, the runZoned runner picks it up and we never see it again.

The "toThrow == null" is there so we throw the first exception, since we can only throw one exception in the $apply function. [ I should write a test for this behaviour... ]

[pavelgj]

BTW, apparently throw; is deprecated. Gotta use "rethrow".

[mhevery]

One comment, LGTM otherwise

[jbdeboer]

Landed in 46c671f