This repository was archived by the owner on Feb 22, 2018. It is now read-only.
feat(blockhole): Change blockhole to have the insert / remove / move instead of block #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/core_dom/block.dart
Outdated
There was a problem hiding this comment.
"A BlockHole is an instance of a hole"
I don't really like the description:
- does not really help undertsanding IMO,
- saying that a class is an instance seems odd
Should this be reworded ?
|
lgtm |
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Mar 7, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.