Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Apr 2, 2014

  • Refactor NgTrueValue and NgFalseValue so that it smells good!
  • Refactor/clean-up InputCheckboxDirective.
  • Update input[type=checkbox] API doc to reflect AngularDart behavior while following AngularJS-like style.

…lse-value

- Refactor `NgTrueValue` and `NgFalseValue` so that it smells good!
- Refactor/clean-up InputCheckboxDirective.
- Update `input[type=checkbox]` API doc to reflect AngularDart behavior.
@chalin
Copy link
Contributor Author

chalin commented Apr 2, 2014

Included in this PR are improvements (refactoring/clean-up) to NgTrueValue and NgFalseValue became evident during discussions with @mhevery et al., mainly while working on #747.

@chalin chalin added cla: yes and removed cla: no labels Apr 2, 2014
mhevery pushed a commit that referenced this pull request Apr 3, 2014
…lse-value

- Refactor `NgTrueValue` and `NgFalseValue` so that it smells good!
- Refactor/clean-up InputCheckboxDirective.
- Update `input[type=checkbox]` API doc to reflect AngularDart behavior.

Closes #842
mhevery pushed a commit that referenced this pull request Apr 3, 2014
…lse-value

- Refactor `NgTrueValue` and `NgFalseValue` so that it smells good!
- Refactor/clean-up InputCheckboxDirective.
- Update `input[type=checkbox]` API doc to reflect AngularDart behavior.

Closes #842
mhevery pushed a commit that referenced this pull request Apr 3, 2014
…lse-value

- Refactor `NgTrueValue` and `NgFalseValue` so that it smells good!
- Refactor/clean-up InputCheckboxDirective.
- Update `input[type=checkbox]` API doc to reflect AngularDart behavior.

Closes #842
@mhevery mhevery closed this in b2458ec Apr 3, 2014
@chalin chalin deleted the patch-0402-refactor-checkbox branch April 4, 2014 01:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

1 participant