This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Fixing expression extractor & test #860
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blois
pushed a commit
that referenced
this pull request
Apr 4, 2014
Noticed that this test was not failing when it should have been, there were two issues- - The packages were not being specified for the test, so the expression extractor was skipping all Angular code. - The source crawler was not including exported libraries which causes it to incorrectly skip chunks of Angular code. End result is that the expression list being extracted was a fraction of what it should have been. Closes #860
Noticed that this test was not failing when it should have been, there were two issues- - The packages were not being specified for the test, so the expression extractor was skipping all Angular code. - The source crawler was not including exported libraries which causes it to incorrectly skip chunks of Angular code. End result is that the expression list being extracted was a fraction of what it should have been.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed during investigation of #747 that this test was not failing when it should have been, there were two issues-
End result is that the expression list being extracted was a fraction of what it should have been.