Skip to content
This repository was archived by the owner on Jun 20, 2019. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
41458dc
Sync to origin master
mk13 Nov 30, 2016
6395e37
Merge with origin master
mk13 Dec 1, 2016
8eedfce
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Dec 9, 2016
1eba56f
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Dec 9, 2016
2e0f1a4
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Dec 10, 2016
9881a95
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Dec 13, 2016
d46b2de
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Dec 16, 2016
6489912
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Dec 24, 2016
c453117
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Dec 28, 2016
dd5fee4
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Jan 5, 2017
ca77fc4
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Jan 9, 2017
b0e3635
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Jan 10, 2017
cdcc5ff
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Jan 10, 2017
1c04147
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Jan 23, 2017
11de100
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Mar 2, 2017
c489fcf
Merge branch 'master' of https://github.com/dart-lang/angular2-dart-a…
mk13 Apr 11, 2017
0be177b
Fix travis build. Fix sdk related errors (ContextRoot and IdeOptions)…
mk13 Apr 11, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions analyzer_plugin/lib/src/angular_driver.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import 'dart:convert';
import 'dart:async';
import 'dart:collection';
import 'package:analysis_server/src/analysis_server.dart';
import 'package:analyzer/context/context_root.dart';
import 'package:analyzer/src/dart/analysis/byte_store.dart';
import 'package:analyzer/error/listener.dart';
import 'package:analyzer/src/generated/sdk.dart';
Expand Down Expand Up @@ -58,6 +59,8 @@ class AngularDriver
_fileTracker = new FileTracker(this);
}

ContextRoot get contextRoot => dartDriver.contextRoot;

ApiSignature getUnitElementHash(String path) {
return dartDriver.getUnitKeyByPath(path);
}
Expand Down
2 changes: 1 addition & 1 deletion analyzer_plugin/lib/src/converter.dart
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ class EmbeddedDartParser {
}

static bool _tokenMatchesBuiltInIdentifier(Token token) =>
token is KeywordToken && token.keyword.isPseudoKeyword;
token is KeywordToken && token.keyword.isBuiltInOrPseudo;

static bool _tokenMatchesIdentifier(Token token) =>
token.type == TokenType.IDENTIFIER ||
Expand Down
1 change: 0 additions & 1 deletion analyzer_plugin/lib/src/directive_linking.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import 'dart:async';
import 'package:analyzer/error/listener.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/dart/element/element.dart';
import 'package:angular_analyzer_plugin/tasks.dart';
import 'package:angular_analyzer_plugin/src/directive_extraction.dart';
import 'package:angular_analyzer_plugin/src/model.dart';
Expand Down
4 changes: 0 additions & 4 deletions analyzer_plugin/lib/src/view_extraction.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@ import 'package:analyzer/src/generated/source.dart';
import 'package:angular_analyzer_plugin/src/model.dart';
import 'package:angular_analyzer_plugin/tasks.dart';
import 'tasks.dart';
import 'package:analyzer/src/generated/constant.dart';
import 'package:analyzer/dart/constant/value.dart';
import 'package:analyzer/dart/element/type.dart';
import 'package:analyzer/error/error.dart';
import 'package:angular_analyzer_plugin/src/selector.dart';
import 'package:html/dom.dart' as html;
import 'package:html/parser.dart' as html;
import 'package:angular_analyzer_plugin/src/angular_html_parser.dart';
Expand Down
6 changes: 5 additions & 1 deletion analyzer_plugin/test/abstract_angular.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
library angular2.src.analysis.analyzer_plugin.src.angular_base;

import 'package:analyzer/file_system/file_system.dart' as fs;
import 'package:analyzer/context/context_root.dart';
import 'package:analyzer/source/package_map_resolver.dart';
import 'package:analyzer/file_system/memory_file_system.dart';
import 'package:analyzer/dart/element/element.dart';
Expand Down Expand Up @@ -128,13 +129,16 @@ class AbstractAngularTest {
packageResolver,
new ResourceUriResolver(resourceProvider)
]);
var testPath = resourceProvider.convertPath('/test');
var contextRoot = new ContextRoot(testPath, []);

dartDriver = new AnalysisDriver(
scheduler,
logger,
resourceProvider,
byteStore,
new FileContentOverlay(),
"test",
contextRoot,
sf,
new AnalysisOptionsImpl());
angularDriver = new AngularDriver(new MockAnalysisServer(), dartDriver,
Expand Down
4 changes: 4 additions & 0 deletions server_plugin/lib/src/embedded_dart_completion_request.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import 'package:analysis_server/src/provisional/completion/dart/completion_dart.
import 'package:analysis_server/src/services/completion/dart/optype.dart';
import 'package:analysis_server/src/provisional/completion/dart/completion_target.dart';
import 'package:analysis_server/src/services/search/search_engine.dart';
import 'package:analysis_server/src/ide_options.dart';
import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
import 'package:analyzer/src/dart/analysis/driver.dart';
import 'package:analyzer/src/generated/source.dart';
Expand Down Expand Up @@ -161,6 +162,9 @@ class EmbeddedDartCompletionRequest implements DartCompletionRequest {
return opType.includeIdentifiers;
}

@override
IdeOptions get ideOptions => null;

/**
* We have to return non null or much code will view this as an isolated part
* file. We will use our template's libraryElement.
Expand Down
32 changes: 18 additions & 14 deletions server_plugin/test/completion_contributor_test_util.dart
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,15 @@ abstract class AbstractDartCompletionContributorTest
Future computeSuggestions([int times = 200]) async {
context.analysisPriorityOrder = [testSource];
CompletionRequestImpl baseRequest = new CompletionRequestImpl(
null,
context,
null,
searchEngine,
testSource,
completionOffset,
new CompletionPerformance());
null,
context,
null,
searchEngine,
testSource,
completionOffset,
new CompletionPerformance(),
null,
);

// Build the request
Completer<DartCompletionRequest> requestCompleter =
Expand Down Expand Up @@ -100,13 +102,15 @@ abstract class AbstractCompletionContributorTest
Future computeSuggestions([int times = 200]) async {
context.analysisPriorityOrder = [testSource];
CompletionRequestImpl request = new CompletionRequestImpl(
null,
context,
null,
searchEngine,
testSource,
completionOffset,
new CompletionPerformance());
null,
context,
null,
searchEngine,
testSource,
completionOffset,
new CompletionPerformance(),
null,
);

// Build the request
Completer<CompletionRequest> requestCompleter =
Expand Down