Skip to content
This repository has been archived by the owner on Sep 12, 2019. It is now read-only.

Figure out how to extend the AST to support Pipes better #16

Closed
matanlurey opened this issue Dec 24, 2016 · 0 comments
Closed

Figure out how to extend the AST to support Pipes better #16

matanlurey opened this issue Dec 24, 2016 · 0 comments
Assignees
@matanlurey
Labels
Type: enhancement

Comments

@matanlurey
Copy link
Contributor

Potentially add a PipeExpression type so a visitPipe can be added for tooling.

@MichaelRFairhurst on #11:

Hmm, I think the only thing about that to me is that the resulting AST has a semantic meaning, just one that existing tools won't like.

I think it'd be best to transform the semantic meaning into a valid one (ie, actually expose $$ng.pipe to users and everything), or create an extension to the AST so that existing tools know that they need to be extended with visitPipe etc before they can work.
@matanlurey matanlurey self-assigned this Dec 24, 2016
@matanlurey matanlurey mentioned this issue Dec 24, 2016
Merged
matanlurey added a commit to matanlurey/angular_ast that referenced this issue Dec 25, 2016
@matanlurey
Implement custom PipeExpression AST
506f038 
Closes dart-archive#16
@matanlurey matanlurey mentioned this issue Dec 25, 2016
Merged
matanlurey added a commit that referenced this issue Jan 5, 2017
@matanlurey
A bunch of cleanup work from prior PRs (#18)
eb44422 
* Add a formal parser for micro expressions

Closes #15

* A bunch of pre 0.2.0 fixes

* Implement custom `PipeExpression` AST

Closes #16

* Update CHANGELOG
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matanlurey matanlurey

Labels
Type: enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matanlurey