This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Next update: closer to a final release. #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Oct 16, 2017
| if (spec.extend != null) { | ||
| output.write(' extends '); | ||
| visitType(spec.extend.toType(), output); | ||
| visitType(spec.extend.type, output); |
There was a problem hiding this comment.
I'm not aware how the visitor pattern is implemented here, but I'd not expect visit* methods call other visit* methods, and instead call accept on child nodes. E.g. here it would be spec.extend.type.accept(this, output).
lib/src/specs/expression.dart
Outdated
| return new BinaryExpression._(expression, other, '&&'); | ||
| } | ||
|
|
||
| /// This expression preceding by `await`. |
| R accept<R>(covariant ExpressionVisitor<R> visitor, [R context]); | ||
|
|
||
| /// Returns the expression as a valid [Code] block. | ||
| /// The expression as a valid [Code] block. |
There was a problem hiding this comment.
nit: "This expression as..."?
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* Fix a number of issues. * OK, add some tests. * Add closures, some getters. * Another refactor. * Added FunctionType. * Updated README. * Dartfmt. * Fix CHANGELOG.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #140.