This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Beta release fixes and feature. #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @yjbanov plz 🗡 |
yjbanov
approved these changes
Oct 24, 2017
|
|
||
| @override | ||
| R accept<R>(SpecVisitor<R> visitor, [R context]) { | ||
| return generate().accept(visitor, context); |
There was a problem hiding this comment.
This not only generates lazily, but also generates every time it's visited. Is it intentional?
There was a problem hiding this comment.
Yeah. We could cache it, but we wouldn't know if the function is stateless or not.
|
|
||
| @override | ||
| R accept<R>(CodeVisitor<R> visitor, [R context]) { | ||
| return generate(visitor).accept(visitor, context); |
|
|
||
| @override | ||
| R accept<R>(CodeVisitor<R> visitor, [R context]) { | ||
| return generate().accept(visitor, context); |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
* Beta release fixes and feature. * Dartfmt.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/tools#844.
Closes dart-lang/tools#845.
Closes dart-lang/tools#846.