Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Ignore abstract methods #412

Merged
merged 14 commits into from
Jul 25, 2022
Merged

Ignore abstract methods #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6f125d6
Fix branch coverage test
liamappelbe Jun 16, 2022
bb4b04e
Ignore implicit functions in function coverage
liamappelbe Jun 16, 2022
8ee4787
Merge branch 'fix_test' into ignore_implicit_funcs
liamappelbe Jun 16, 2022
0e5537f
Add a dedicated function coverage test.
liamappelbe Jun 16, 2022
d23bdd9
Fix analysis
liamappelbe Jun 16, 2022
b3eba93
Merge branch 'master' into ignore_implicit_funcs
liamappelbe Jun 21, 2022
ad45d9e
Ignore abstract functions
liamappelbe Jun 21, 2022
f52f8c0
Merge branch 'ignore_implicit_funcs' into abstract
liamappelbe Jun 21, 2022
99725fa
Merge branch 'master' into abstract
liamappelbe Jul 6, 2022
e52fe03
Use the new vm_service version
liamappelbe Jul 6, 2022
e76abeb
Fix test
liamappelbe Jul 6, 2022
622bb69
vm_service abstract update was actually a minor version bump
liamappelbe Jul 20, 2022
2f1dfac
Remove deprecated analysis option
liamappelbe Jul 20, 2022
efb5472
Fix function_coverage_test on older SDKs
liamappelbe Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ linter:
- control_flow_in_finally
- empty_statements
- hash_and_equals
- invariant_booleans
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- literal_only_boolean_expressions
Expand Down
2 changes: 1 addition & 1 deletion lib/src/collect.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ Future<List<Map<String, dynamic>>> _getCoverageJson(

Future<void> processFunction(FuncRef funcRef) async {
final func = await service.getObject(isolateRef.id!, funcRef.id!) as Func;
if (func.implicit ?? false) {
if ((func.implicit ?? false) || (func.isAbstract ?? false)) {
return;
}
final location = func.location;
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies:
path: ^1.8.0
source_maps: ^0.10.10
stack_trace: ^1.10.0
vm_service: ^9.0.0
vm_service: ^9.2.0

dev_dependencies:
build_runner: ^2.1.10
Expand Down
4 changes: 2 additions & 2 deletions test/function_coverage_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void main() {
final isolateFile = hitMap[_sampleAppFileUri]!;
expect(isolateFile.funcHits, {
7: 1,
12: 0, // TODO(#398): This abstract method should be ignored.
if (!platformVersionCheck(2, 19)) 12: 0,
16: 1,
21: 1,
25: 1,
Expand All @@ -43,7 +43,7 @@ void main() {
});
expect(isolateFile.funcNames, {
7: 'normalFunction',
12: 'BaseClass.abstractMethod',
if (!platformVersionCheck(2, 19)) 12: 'BaseClass.abstractMethod',
16: 'SomeClass.SomeClass',
21: 'SomeClass.normalMethod',
25: 'SomeClass.staticMethod',
Expand Down