This repository was archived by the owner on Dec 6, 2017. It is now read-only.
Code cleanup, edited tests, and updated benchmarks #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
There was a problem hiding this comment.
remove alpha.2 until we cut a new release
mhevery
pushed a commit
that referenced
this pull request
Jun 27, 2014
|
Closed by: 68fc32d |
There was a problem hiding this comment.
should be toFactory: (...) => ..., same below
should inject: [...] be added here also ? toFactory(a0, a1, …) => new Instance(a0, a1, …), inject: [a0Key, a1Key, ...]
There was a problem hiding this comment.
inject should be passed in when bind is called, i.e. bind(toFactory, inject, ...) as shown below. This just specifies the typeFactories format.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.