This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Refactor AutolinkExtensionSyntax #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzhiguang
commented
Oct 24, 2022
| static final Config gfmConfig = Config._( | ||
| 'gfm', | ||
| 'https://github.github.com/gfm/', | ||
| ExtensionSet.gitHubFlavored, |
There was a problem hiding this comment.
The ExtensionSet.gitHubFlavored does not work out here. Because AutolinkExtensionSyntax and AutolinkSyntax conflict to each other.
For example:
https://github.github.com/gfm/#example-620
http://example.comWithout AutolinkExtensionSyntax, the result is:
<p>http://example.com</p>With AutolinkExtensionSyntax, the result is:
<p><a href="http://example.com">http://example.com</a></p>
Merged
chenzhiguang
force-pushed
the
Refactor-AutolinkExtensionSyntax
branch
from
1abc5b8 to
01e126b
Compare
|
@srawlins hi, I have created 3 more PRs. I am not sure if I need to ping you each time when I have created a new PR, so it will show up somewhere on your dashboard. 🙂 |
kevmoo
reviewed
Oct 25, 2022
kevmoo
reviewed
Oct 25, 2022
chenzhiguang
force-pushed
the
Refactor-AutolinkExtensionSyntax
branch
from
1b7fa9a to
7e6362c
Compare
Pull Request Test Coverage Report for Build 3326057450Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
chenzhiguang
force-pushed
the
Refactor-AutolinkExtensionSyntax
branch
from
7e6362c to
eea7e9f
Compare
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
* Refactor AutolinkExtensionSyntax Fix https://github.com/dart-lang/markdown/issues/470 * Improve readability * optimise a bit * Fix some requests from reveiw * Update gfm_stats.txt * An optimisation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the readability and test coverage.
Fix: dart-lang/tools#1315