Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Oct 25, 2022

A number of the deprecated classes in block_syntaxes were not exposed,
so not including those in the changelog

@kevmoo kevmoo requested a review from srawlins October 25, 2022 18:21

## 6.0.1

* Fix a crash in checkbox lists when mixing checkbox items with
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got all messed up. Tried to fix...

@coveralls
Copy link

coveralls commented Oct 25, 2022

Pull Request Test Coverage Report for Build 3323468081

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.197%

Totals Coverage Status
Change from base Build 3323218311: 0.2%
Covered Lines: 1209
Relevant Lines: 1270

💛 - Coveralls

@kevmoo kevmoo requested a review from srawlins October 25, 2022 18:47
@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 1, 2022

Thoughts @srawlins ?

Copy link
Collaborator

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do love it. I think I'd like to wait for #481 to land first (which in turn is blocked on something else 😮‍💨 )

A number of the deprecated classes in block_syntaxes were not exposed,
so not including those in the changelog
@kevmoo kevmoo force-pushed the drop_deprecated_apis branch from 321eb75 to 6a01018 Compare November 7, 2022 18:04
@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 7, 2022

@srawlins – ready for another review

@srawlins srawlins merged commit 1d6f210 into master Nov 8, 2022
@srawlins srawlins deleted the drop_deprecated_apis branch November 8, 2022 02:15
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
A number of the deprecated classes in block_syntaxes were not exposed,
so not including those in the changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants