Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

chenzhiguang
Copy link
Contributor

Strictly improves the test coverage.

@coveralls
Copy link

coveralls commented Oct 28, 2022

Pull Request Test Coverage Report for Build 3346492779

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 95.008%

Totals Coverage Status
Change from base Build 3323865806: 0.04%
Covered Lines: 1218
Relevant Lines: 1282

💛 - Coveralls

Copy link
Collaborator

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little fix! One nit.

@chenzhiguang chenzhiguang force-pushed the Improve-BlockquoteSyntax branch 2 times, most recently from 21a90ed to 150c895 Compare October 29, 2022 16:16
@chenzhiguang
Copy link
Contributor Author

Rebased

@chenzhiguang chenzhiguang force-pushed the Improve-BlockquoteSyntax branch 2 times, most recently from 150c895 to c069434 Compare October 31, 2022 16:55
@kevmoo
Copy link
Contributor

kevmoo commented Nov 4, 2022

@chenzhiguang – please rebase on master – we now have flutter_markdown validation in place

If there are breaks there, we'll have to dig to see what's expected/intended.

@chenzhiguang chenzhiguang force-pushed the Improve-BlockquoteSyntax branch from 191cc4c to 3c75a37 Compare November 4, 2022 05:49
@chenzhiguang
Copy link
Contributor Author

Rebased

@chenzhiguang chenzhiguang force-pushed the Improve-BlockquoteSyntax branch 2 times, most recently from 6bed52b to 9f602a3 Compare November 4, 2022 06:14
@chenzhiguang
Copy link
Contributor Author

Benchmark

Before

Screenshot 2022-11-04 at 18 01 48

After

Screenshot 2022-11-04 at 18 29 16

@chenzhiguang chenzhiguang force-pushed the Improve-BlockquoteSyntax branch 3 times, most recently from 49f1e50 to 0bb11ac Compare November 8, 2022 16:45
@chenzhiguang chenzhiguang force-pushed the Improve-BlockquoteSyntax branch from 0bb11ac to 8e9ba3b Compare November 8, 2022 16:54
@kevmoo kevmoo requested a review from srawlins November 8, 2022 17:12
@chenzhiguang chenzhiguang force-pushed the Improve-BlockquoteSyntax branch from 155f3df to 8e9ba3b Compare November 8, 2022 17:14
It was not an issue until merged this updated FencedCodeBlockSyntax into current branch
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Collaborator

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@srawlins srawlins merged commit a70b93a into dart-archive:master Nov 9, 2022
@chenzhiguang chenzhiguang deleted the Improve-BlockquoteSyntax branch November 9, 2022 18:31
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
* Improve BlockquoteSyntax

* Fix a comment

* Fix a FencedCodeBlockSyntax issue

It was not an issue until merged this updated FencedCodeBlockSyntax into current branch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants