Skip to content

pass the provided root instead of the resolved root for project type detection #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

pass the provided root instead of the resolved root for project type detection #150

merged 1 commit into from
May 29, 2025

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented May 29, 2025 •
edited
Loading

Changed commandForRoot and inferProjectRoot to take a String (the root uri) instead of a Root or support this.

@jakemac53 jakemac53 requested a review from gspencergoog May 29, 2025 20:25
@github-actions GitHub Actions
Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

gspencergoog
gspencergoog approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@jakemac53 jakemac53 merged commit 2a5eb30 into main May 29, 2025
13 checks passed
@jakemac53 jakemac53 deleted the use-proper-root branch May 29, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

package:dart_mcp_server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakemac53 @gspencergoog