add an example of using progress tokens to the tools example #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
|
We might eventually want to make this a bit more ergonomic too - such as including a factory for creating unique progress tokens. |
bwilkerson
approved these changes
Aug 22, 2025
| ), | ||
| const delayMs = 2000; | ||
| print( | ||
| 'Calling `${tool.name}` tool, with an artificial ${delayMs}ms second ' |
| meta: MetaWithProgressToken(progressToken: ProgressToken(1)), | ||
| ); | ||
| // Make sure to listen before awaiting the response - you could listen | ||
| // after sending the request but before awaiting the result as well. |
There was a problem hiding this comment.
If both scenarios should work then we should probably test both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially created this just for testing Gemini CLI support for progress tokens, but it makes sense to land.