Skip to content

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Sep 17, 2025

Watcher tests:

  • Convert many tests to equivalent e2e tests. Rename watch_command_invalidation_test -> watch_command_test and add to that.
  • Drop complex invalidation tests as those are best covered by unit tests.
  • Drop pubspec.yaml "delayed read" test as that behaviour will be removed soon.

BuildRunnerTester:

  • Improved logging around waiting for process output
  • Add timeout when waiting for process output
  • Stop using TestProcess as there is no way to stop it writing the whole process output when the process exits, just use Process
  • Add expectNoOutput

Copy link

PR Health

Changelog Entry
Package Changed Files
package:build_runner build_runner/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@davidmorgan davidmorgan merged commit 310cd82 into dart-lang:master Sep 17, 2025
32 of 33 checks passed
@davidmorgan davidmorgan deleted the watcher-test branch September 17, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants