Skip to content

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Sep 22, 2025

Now that build config is loaded at runtime and not part of the generated script, it can be reloaded without restarting.

Remove log output about build_runner internal steps: these are very quick, it doesn't add much.

Remove log output about whether it's an incremental build or if not, why. You can tell if it's an incremental build from the detailed output about what's being built. Some tests were relying on this output for verification: change to better test cases that produce different output on disk instead.

Improvements to BuildRunnerTester.expectNoOutput for when it fails.

Copy link

github-actions bot commented Sep 22, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@davidmorgan davidmorgan force-pushed the build-config-changes branch 5 times, most recently from 16c1a4a to 4195dff Compare September 22, 2025 13:44
@davidmorgan davidmorgan marked this pull request as ready for review September 22, 2025 13:57
@davidmorgan davidmorgan merged commit de722ae into dart-lang:master Sep 23, 2025
33 checks passed
@davidmorgan davidmorgan deleted the build-config-changes branch September 23, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants