Run end to end tests on macos. #4229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
force-pushed
the
test-on-mac
branch
from
1cd8380 to
3149329
Compare
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
davidmorgan
force-pushed
the
test-on-mac
branch
13 times, most recently
from
4cd4f23 to
657202a
Compare
davidmorgan
force-pushed
the
test-on-mac
branch
from
657202a to
82b8c9c
Compare
jensjoha
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start testing on MacOS.
Fix a bug in
build_daemonthat this uncovers. The system temp folder on Mac is symlinked, and this was causing the build daemon e2e test to fail because of the test and the build daemon treating the symlink-unresolved workspace as different from the symlink-resolved workspace.There is some flakiness in the daemon end to end test related to unexpected file change events, "add" of an existing file, but this code will change soon so live with the flakiness for now.