Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcoming breaking change: Datagram.data -> Uint8List #381

Closed
tvolkert opened this issue Jun 11, 2019 · 0 comments
Closed

Upcoming breaking change: Datagram.data -> Uint8List #381

tvolkert opened this issue Jun 11, 2019 · 0 comments

Comments

@tvolkert
Copy link
Contributor

Per dart-lang/sdk#36900, a pending change has been prepared in the Dart SDK that changes Datagram.data to be Uint8List.

This change breaks co19 with errors like the following:

stderr:
ERROR|COMPILE_TIME_ERROR|STRONG_MODE_INVALID_CAST_LITERAL_LIST|/b/s/w/ir/cache/builder/sdk/tests/co19_2/src/LibTest/io/Datagram/Datagram_A01_t01.dart|16|36|9|The list literal type 'List<int>' isn't of expected type 'Uint8List'. The list's type can be changed with an explicit generic type argument or by changing the element types.

I've made the necessary changes to co19 here. Can you please make this forwards-compatible change here to make this rollout a soft transition?

Thanks!
tvolkert added a commit to tvolkert/co19 that referenced this issue Jun 11, 2019
@tvolkert
Pass Uint8List to Datagram
b4ca55d 
This is in preparation for Datagram requiring a
Uint8List passed to its constructor. This is a
forward-compatible change.

dart-lang/sdk#36900
dart-lang#381
@tvolkert tvolkert mentioned this issue Jun 11, 2019
Merged
athomas pushed a commit that referenced this issue Jun 11, 2019
@tvolkert @athomas
Pass Uint8List to Datagram (#382)
6ccebbf 
This is in preparation for Datagram requiring a
Uint8List passed to its constructor. This is a
forward-compatible change.

dart-lang/sdk#36900
#381
tvolkert added a commit to tvolkert/co19 that referenced this issue Jun 12, 2019
@tvolkert
Fix a few remaining call-sites
7cd0a87 
There were a few places where `.cast<List<int>>()` calls were
missed in dart-lang#384 and dart-lang#385, and likewise for `Datagram.data` in dart-lang#382.

Note that I had to change one of the tests of `Datagram.data`, since
the existing test was setting invalid values as the data (signed
integers or integers that didn't fit in 8-bytes).

dart-lang/sdk#36900
dart-lang#381
dart-lang#383
@tvolkert tvolkert mentioned this issue Jun 12, 2019
Merged
athomas pushed a commit that referenced this issue Jun 12, 2019
@tvolkert @athomas
Fix a few remaining call-sites (#386)
b0220fc 
There were a few places where `.cast<List<int>>()` calls were
missed in #384 and #385, and likewise for `Datagram.data` in #382.

Note that I had to change one of the tests of `Datagram.data`, since
the existing test was setting invalid values as the data (signed
integers or integers that didn't fit in 8-bytes).

dart-lang/sdk#36900
#381
#383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tvolkert