Pass Uint8List to Datagram #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for Datagram requiring a Uint8List passed to its constructor. This is a forward-compatible change. dart-lang/sdk#36900 dart-lang#381
athomas
approved these changes
Jun 11, 2019
Yeah a separate change makes sense to me. |
|
@sgrekhov can you merge this for me? |
|
(or @athomas if you have commit access on this repo too 🙂 ) |
tvolkert
added a commit
to tvolkert/co19
that referenced
this pull request
Jun 12, 2019
There were a few places where `.cast<List<int>>()` calls were missed in dart-lang#384 and dart-lang#385, and likewise for `Datagram.data` in dart-lang#382. Note that I had to change one of the tests of `Datagram.data`, since the existing test was setting invalid values as the data (signed integers or integers that didn't fit in 8-bytes). dart-lang/sdk#36900 dart-lang#381 dart-lang#383
athomas
pushed a commit
that referenced
this pull request
Jun 12, 2019
There were a few places where `.cast<List<int>>()` calls were missed in #384 and #385, and likewise for `Datagram.data` in #382. Note that I had to change one of the tests of `Datagram.data`, since the existing test was setting invalid values as the data (signed integers or integers that didn't fit in 8-bytes). dart-lang/sdk#36900 #381 #383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for Datagram requiring a
Uint8List passed to its constructor. This is a
forward-compatible change.
dart-lang/sdk#36900
#381