Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2833. Initializer of a wildcard variable should be executed #2834

Closed
wants to merge 1 commit into from
Closed

Fixes #2833. Initializer of a wildcard variable should be executed #2834

wants to merge 1 commit into from

Conversation

sgrekhov
Copy link
Contributor

No description provided.

eernstg
eernstg approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg
Copy link
Member

eernstg commented Aug 27, 2024

Double-checking the change, I concluded that this change should probably not be landed. The expectations were correct already before the change.

@kallentu and @sgrekhov,did I miss something, do you see any reason why init would ever be invoked during the execution of this program?

@sgrekhov
Copy link
Contributor Author

Agreed. Missed that these variables are late.

@kallentu kallentu mentioned this pull request Aug 27, 2024
Closed
@kallentu
Copy link
Member

Further discussion in #2833.
We can probably close this PR.

@kallentu kallentu closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

@kallentu kallentu Awaiting requested review from kallentu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgrekhov @eernstg @kallentu