-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable --wasm flag for production builds #3039
Conversation
Cool. Thanks!
I'm able to run other Flutter web apps with Wasm, but the staged version at the link you sent seems to still be running with (or picking) JS. Is it the wrong link or do you still expect that? |
Sorry, wrong link: https://dart-pad-a3c64--wasm-cdjiko6q.web.app/ |
This doesn't appear to be related to Wasm, but seems to be happening due to a timing issue related to calling refresh() on the Codemirror API. I patched this issue by adding an artificial delay whenever a new CodeMirror platform view is created: 75542ec |
Updated staging link: https://dart-pad-a3c64--wasm-cdjiko6q.web.app/ |
With this link: https://dart-pad-a3c64--wasm-cdjiko6q.web.app/, I don't see content in the codemirror editor until I click inside it. (ed: perhaps an intermittent issue?) |
63b1d9d should fix that. Updated staging link: https://dart-pad-a3c64--wasm-cdjiko6q.web.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
The UI is working nicely when built with the latest version Flutter engine, so it would be great to start using Wasm for the production version of DartPad. (The remaining issues with platform views have been fixed on the main channel of the SDK.)
Here's a staged version built with the
--wasm
flag, using the latest Flutter SDK (main channel): https://dart-pad-a3c64--wasm-cdjiko6q.web.app/I made sure to update the Flutter SDK images to the latest version of the
main
channel of the SDK in GCP, so once this is merged it should use those images.