Skip to content

install gcloud and run tests that need gsutil #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

install gcloud and run tests that need gsutil #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa7e492
install gcloud and run tests that need gsutil
jakemac53 Jun 11, 2025
e2c292e
add some debug commands
jakemac53 Jun 11, 2025
2d8cac0
revert debug logs, use gsutil instead of gsutil.py
jakemac53 Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/baseline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,13 @@ jobs:
- uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
with:
sdk: ${{ matrix.sdk }}
- name: 'Set up Cloud SDK'
uses: 'google-github-actions/setup-gcloud@77e7a554d41e2ee56fc945c52dfd3f33d12def9a'

- run: dart pub get

- run: dart analyze --fatal-infos

- run: dart format --output=none --set-exit-if-changed .

# TODO: Install gsutil and un-skip tests that require it
- run: dart test -x requires_gsutil
- run: dart test
4 changes: 2 additions & 2 deletions baseline/lib/baseline.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,11 @@ Future<void> baselineBuilder(
}

Future<String> read(String url) {
return run('gsutil.py', ['cp', url, '-']);
return run('gsutil', ['cp', url, '-']);
}

Future<String> write(String url, String stdin, bool dryRun) {
return run('gsutil.py', ['cp', '-', url], stdin: stdin, dryRun: dryRun);
return run('gsutil', ['cp', '-', url], stdin: stdin, dryRun: dryRun);
}

Future<String> run(String command, List<String> arguments,
Expand Down
Loading