Enums show the wrong number

[Hixie]

http://docs.flutter.io/flutter/widgets/Orientation-class.html

portrait has value 0, landscape has value 1. But the docs say 1 and 2 respectively.

See also #1094 which mentions this.

[eseidelGoogle]

This looks like the code in question:

dartdoc/lib/src/model.dart

Line 689 in 5b93362

class Enum extends Class {

[eseidelGoogle]

I've found the bug:

pub run test test/model_test.dart -n constant
00:18 +2: Enum has correct number of constants                                                     
0
List<Animal> values
1
Animal CAT
2
Animal DOG
3
Animal HORSE

With this patch:

diff --git a/lib/src/model.dart b/lib/src/model.dart
index 25c571c..284fdf1 100644
--- a/lib/src/model.dart
+++ b/lib/src/model.dart
@@ -727,7 +727,10 @@ class EnumField extends Field {
   EnumField(FieldElement element, Library library) : super(element, library);

   EnumField.forConstant(this._index, FieldElement element, Library library)
-      : super(element, library);
+      : super(element, library) {
+    print(this._index);
+    print(element);
+  }

   @override
   String get constantValue {
diff --git a/test/model_test.dart b/test/model_test.dart
index 7850252..6e0581a 100644
--- a/test/model_test.dart
+++ b/test/model_test.dart
@@ -733,7 +733,7 @@ void main() {
       var dog = animal.constants.firstWhere((f) => f.name == 'DOG');
       expect(dog.linkedName, equals('DOG'));
       expect(dog.isConst, isTrue);
-      expect(dog.constantValue, equals('const Animal(2)'));
+      expect(dog.constantValue, equals('const Animal(1)'));
     });

     test('has a single `index` property', () {

Not yet sure what the right fix is.

[eseidelGoogle]

I tried using isEnumConstant from FieldElement in the analyzer api, and things got worse. o_O?

00:17 +2: Enum has correct number of constants                                                     
0
int index
1
List<Animal> values
2
Animal CAT
3
Animal DOG
4
Animal HORSE

[keertip]

@eseidelGoogle, thanks for digging into this. Maybe dartdoc is not using the right accessors to get to the values. Will check with the analyzer team on Monday (ooo today) and get this fixed.

[pq]

I think Eric's proposed fix is not a bad (at least interim) fix. Happy to help pull from the analyzer side if appropriate.

[Hixie]

Yeah, EnumField already special-cases "values" all over the place.