Skip to content

general code review: use final, private, etc #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2015
Merged

general code review: use final, private, etc #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/dartdoc.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@ List<Generator> initGenerators(String url) {
/// Generates Dart documentation for all public Dart libraries in the given
/// directory.
class DartDoc {
List<String> _excludes;
Directory _rootDir;
final List<String> _excludes;
final Directory _rootDir;
final Directory _sdkDir;
final bool _sdkDocs;
final Set<LibraryElement> libraries = new Set();
final List<Generator> _generators;

Directory out;
Directory _sdkDir;
bool _sdkDocs;
Set<LibraryElement> libraries = new Set();
List<Generator> _generators;

DartDoc(this._rootDir, this._excludes, this._sdkDir, this._generators,
[this._sdkDocs = false]);
Expand Down
4 changes: 2 additions & 2 deletions lib/generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import 'src/model.dart';
/// for a given package. Generators can generate documentation in different
/// formats - html, json etc
abstract class Generator {
Package package;
Directory out;
Package get package;
Directory get out;

Generator();

Expand Down
Loading