Go to the first suggestion in the search field on Enter [#1149] #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, typeahead.js doesn't give us any API for fetching current
suggesions, so we workaround that by adding `href` of a suggesion into
a data attribute of HTML for that suggestion, and then fetching
suggestions from DOM, choosing the first one, and using it's
`data-href`. Quite dirty though :( I'd prefer to do something like
`typeAheadElement.typeadead('suggestions')[0].href` instead.
Testing: Checked that functionality in latest Chrome, Firefox and Safari
Fixes dart-lang#1149
astashov
force-pushed
the
improve-ui-of-search-field
branch
from
7e0ae1e to
c236ca0
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, typeahead.js doesn't give us any API for fetching current
suggesions, so we workaround that by adding
hrefof a suggesion intoa data attribute of HTML for that suggestion, and then fetching
suggestions from DOM, choosing the first one, and using it's
data-href. Quite dirty though :( I'd prefer to do something liketypeAheadElement.typeadead('suggestions')[0].hrefinstead.Testing: Checked that functionality in latest Chrome, Firefox and Safari
Fixes #1149