Use only canonical elements when resolving unresolved refs in comments #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't do that, dartdoc will think there's ambiguity if several libs export the same elements (like in Flutter, e.g. `widgets` exports `Flexible` and `material` exports `Flexible`). And we won't get links for these references and will get warnings about ambiguity in stderr. Testing: Generated Flutter docs, made sure `fit` from `Flexible` class resolves correctly and doesn't produce a warning Fixes dart-lang#1328
astashov
force-pushed
the
use-canonical-elements-for-resolving-references
branch
from
d788f79 to
095869b
Compare
|
Adding @keertip to review |
|
Any chance we could bump the priority on this and get a deploy to dartdocs.org? Our docs for RxDart are broken as well due to this bug :( |
keertip
approved these changes
Feb 14, 2017
|
Will publish a version with this fix so that dartdocs.org can be updated. Sorry for the delay. |
|
👍 Thanks for the help @keertip!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't do that, dartdoc will think there's ambiguity if several
libs export the same elements (like in Flutter, e.g.
widgetsexportsFlexibleandmaterialexportsFlexible). And we won't get linksfor these references and will get warnings about ambiguity in
stderr.
Testing: Generated Flutter docs, made sure
fitfromFlexibleclassresolves correctly and doesn't produce a warning
Fixes #1328