Skip to content

Conversation

jcollins-g
Copy link
Contributor

There's no framework currently for end-to-end testing of our template output outside manual review of the outputted HTML. To make that easier:

Before:
before

After:
after

Regression for this issue is prevented by an assert for now.

@jcollins-g jcollins-g requested a review from devoncarew May 8, 2017 16:50
@googlebot googlebot added the cla: yes Google CLA check succeeded. label May 8, 2017
@override
String get documentation {
// Verify that we will show exactly one of the summaries.
Set<bool> assertCheck = new Set()..addAll([hasSetter, hasGetterNoSetter]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble parsing this - what are we asserting here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that hasSetter and hasGetterNoSetter are mutuablly exclusive.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@devoncarew
Copy link
Member

lgtm

@jcollins-g jcollins-g merged commit 2d88c17 into master May 9, 2017
@jcollins-g jcollins-g deleted the cleanups branch May 9, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants