Skip to content

Use pkg:build_version to populate the version of the package in code #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

Use pkg:build_version to populate the version of the package in code #1751

merged 1 commit into from
Sep 11, 2018

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Sep 1, 2018

No description provided.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Sep 1, 2018
@kevmoo kevmoo mentioned this pull request Sep 1, 2018
Closed
4 tasks
@kevmoo kevmoo requested a review from jcollins-g September 4, 2018 16:35
@jcollins-g
Copy link
Contributor

Nice! LGTM

@jcollins-g jcollins-g merged commit d038901 into master Sep 11, 2018
@kevmoo kevmoo deleted the build_version branch September 11, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevmoo @jcollins-g @googlebot