Fix bug in warnings where not specifying --show-warnings caused dartdoc to succeed even if there were errors. #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Oct 17, 2018
…oc to succeed even if there were errors.
gspencergoog
force-pushed
the
error_fail
branch
from
97dbad9 to
bb3e5d2
Compare
|
Hmm. @jcollins-g: looks like this bug has been here a while... The tests are failing because dartdoc is now (correctly!) failing because of errors in the test package. I think I'll try and move the ones that are supposed to fail into a separate package. |
gspencergoog
force-pushed
the
error_fail
branch
from
4fbfff3 to
86a4b81
Compare
jcollins-g
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some tests to make sure that external tool failures make dartdoc exit with a non-zero exit code.